Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in dynamic version #102

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

esheldon
Copy link
Contributor

extra "." at the beginning of the package/module spec

extra "." at the beginning of the package/module spec
@esheldon
Copy link
Contributor Author

This bug prevented the package from being installed using setuptools 70 which is default on github now

@esheldon
Copy link
Contributor Author

@JoanneBogart Can you have a look at this one?

Copy link
Collaborator

@JoanneBogart JoanneBogart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for finding and fixing.

@JoanneBogart
Copy link
Collaborator

JoanneBogart commented May 28, 2024

@esheldon are you able to merge?
Probably not. I will go ahead and do it.
Let me know if you'd like permission in case this comes up in the future.

@JoanneBogart JoanneBogart merged commit 7f0d02b into LSSTDESC:main May 28, 2024
1 check passed
@esheldon
Copy link
Contributor Author

I don't have permission, thanks for merging.

@JoanneBogart JoanneBogart mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants